shauryachats commented on code in PR #17278:
URL: https://github.com/apache/pinot/pull/17278#discussion_r2621659756
##########
pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/series/TimeSeriesBlock.java:
##########
@@ -41,7 +43,11 @@ public class TimeSeriesBlock {
/**
* Holds optional metadata about the block (e.g., statistics).
*/
- private Map<String, String> _metadata;
+ private final Map<String, String> _metadata;
+ /**
+ * Holds exceptions encountered during processing of the block.
+ */
+ private final List<QueryException> _exceptions;
Review Comment:
Just to clarify what I mentioned earlier: we can look at handling exceptions
versus warnings for the time-series logic in a future PR, and rely on that
instead of throwing raw exceptions.
Since this PR is really about enabling partial results, it probably makes
sense not to change the broader error-handling approach here. That said, this
does set the groundwork for tightening up the full exception-handling flow
through TimeSeriesBlock in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
