krishan1390 commented on code in PR #17387:
URL: https://github.com/apache/pinot/pull/17387#discussion_r2625973591
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/PinotSegmentColumnReaderImpl.java:
##########
@@ -200,43 +201,43 @@ public byte[] nextBytes() {
}
@Override
- public int[] nextIntMV() {
+ public MultiValueResult<int[]> nextIntMV() {
if (!hasNext()) {
throw new IllegalStateException("No more values available");
}
int[] value = _segmentColumnReader.getIntMV(_currentIndex);
_currentIndex++;
- return value;
+ return MultiValueResult.of(value, null);
Review Comment:
lets document that pinot doesn't support nulls in MV and thus we're passing
null to validity vector
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/readers/PinotSegmentColumnReaderImplTest.java:
##########
@@ -359,22 +360,23 @@ public void testSingleValueAccessors(String columnName,
SingleValueGetter random
@DataProvider(name = "multiValueAccessorProvider")
public Object[][] multiValueAccessorProvider() {
// Base column configurations
+ // For primitive MV types, we need to extract .getValues() from
MultiValueResult
Review Comment:
lets add assertions that hasNulls() returns false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
