Jackie-Jiang commented on PR #17377: URL: https://github.com/apache/pinot/pull/17377#issuecomment-3676967140
Thanks for the contribution! Currently `SegmentDictionaryCreator` has assumptions that all values must have already been added before the lookup. There is no check for performance reason. Do you see it being violated anywhere? If it is violated just in the test, let's fix the test instead. We can also add some javadoc in `SegmentDictionaryCreator` to explain the assumptions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
