gortiz commented on code in PR #17328:
URL: https://github.com/apache/pinot/pull/17328#discussion_r2642337720
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -849,6 +860,11 @@ public static class QueryOptionKey {
// MAX(stringCol) -> MAXSTRING(stringCol)
// SUM(intCol) -> SUMINT(intCol)
public static final String AUTO_REWRITE_AGGREGATION_TYPE =
"autoRewriteAggregationType";
+
+ /// Option to customize the value of
[Broker#CONFIG_OF_SORT_EXCHANGE_COPY_THRESHOLD]
+ public static final String SORT_EXCHANGE_COPY_THRESHOLD =
"sortExchangeCopyThreshold";
+
+ public static final int DEFAULT_SORT_EXCHANGE_COPY_THRESHOLD = -1;
Review Comment:
As said in CONFIG_OF_SORT_EXCHANGE_COPY_THRESHOLD, -1 means it is
implementation dependent. The idea is that by using it, we can change it in the
future without breaking backward compatibility. But TBH, we are usually that
format and we could use 10k
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
