Copilot commented on code in PR #17425:
URL: https://github.com/apache/pinot/pull/17425#discussion_r2645380305
##########
pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthPrincipalExtractor.java:
##########
@@ -28,22 +28,25 @@
import java.util.Set;
import java.util.stream.Collectors;
import org.apache.commons.lang3.StringUtils;
+import org.apache.pinot.common.auth.BasicAuthTokenUtils;
import org.apache.pinot.spi.config.user.UserConfig;
import org.apache.pinot.spi.env.PinotConfiguration;
/**
- * Utility for configuring basic auth and parsing related http tokens
+ * Utility for extracting and constructing BasicAuth principals
+ * from configuration and user metadata, including permissions,
+ * table access rules, and row-level security (RLS) filters.
Review Comment:
The Javadoc should use proper formatting with `@` tags. Consider
reformatting as: "Utility for extracting and constructing BasicAuth principals
from configuration and user metadata, including permissions, table access
rules, and row-level security (RLS) filters." as a single paragraph or using
proper `<p>` tags if multiple paragraphs are needed.
```suggestion
* Utility for extracting and constructing BasicAuth principals from
configuration and user metadata, including
* permissions, table access rules, and row-level security (RLS) filters.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
