yashmayya opened a new pull request, #17438: URL: https://github.com/apache/pinot/pull/17438
- Legacy PQL behavior in [RequestUtils::getLiteral](https://github.com/apache/pinot/blob/fd68b78cdb985f249be7d1597af5054df1914007/pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java#L249) replaces `''` with `'` in string literals (https://github.com/apache/pinot/pull/8626) - Calcite SQL parser already handles this standard SQL escaping. - This caused double-unescaping: `''''` (4 quotes) → `''` (Calcite) → `'` (RequestUtils::getLiteral) instead of staying as `''` - This patch fixes the above issue and introduces a config to retain the existing behavior for easier migration. - Added `InstanceConfigProvider` singleton in `pinot-spi` for global access to instance config (broker / server, can be extended to controller / minion) from any module. Note that this pattern can be used in various scenarios in the future but is particularly useful here because we need to access the configuration from a static context that can be called from a broker path (Main SQL query parsing, time series request handler, RLS filter rewriter) or a server path (JSON index filter parsing, theta sketch agg function, time series server side execution). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
