shauryachats commented on code in PR #17439:
URL: https://github.com/apache/pinot/pull/17439#discussion_r2651831061
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -525,8 +526,12 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
routeProvider = _implicitHybridTableRouteProvider;
}
+ // Get the appropriate routing manager based on query options
+ RoutingManager routingManager = _multiClusterRoutingContext != null &&
logicalTableConfig != null
+ ?
_multiClusterRoutingContext.getRoutingManager(pinotQuery.getQueryOptions())
+ : _routingManager;
// Get the tables hit by the request
- TableRouteInfo routeInfo = routeProvider.getTableRouteInfo(tableName,
_tableCache, _routingManager);
+ TableRouteInfo routeInfo = routeProvider.getTableRouteInfo(tableName,
_tableCache, routingManager);
Review Comment:
Good point. The intent was to keep `_routingManager` semantics unchanged and
limit the change to the per-query path. Renaming `routingManager` to
`selectedRoutingManager` makes the selection explicit and also tells us this
path uses a conditional routing manager.
Renaming `_routingManager` would be much broader given its usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
