Jackie-Jiang commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r338764293
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -471,9 +499,18 @@ public ColumnDataSource getDataSource(String columnName) {
public GenericRow getRecord(int docId, GenericRow reuse) {
for (FieldSpec fieldSpec : _physicalFieldSpecs) {
String column = fieldSpec.getName();
- reuse.putField(column, IndexSegmentUtils
+ Object value = IndexSegmentUtils
.getValue(docId, fieldSpec, _indexReaderWriterMap.get(column),
_dictionaryMap.get(column),
- _maxNumValuesMap.getOrDefault(column, 0)));
+ _maxNumValuesMap.getOrDefault(column, 0));
+ reuse.putValue(column, value);
+
+ if (_nullHandlingEnabled) {
+ NullValueVectorReader reader = _nullValueVectorMap.get(column);
+ // If column has null value for this docId, set that accordingly in
GenericRow
+ if (reader != null && reader.isNull(docId)) {
Review comment:
reader should never be null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
