xiangfu0 commented on code in PR #17457:
URL: https://github.com/apache/pinot/pull/17457#discussion_r2663668164
##########
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##########
@@ -41,6 +42,21 @@
*/
public interface BrokerResponse {
static final Logger LOGGER = LoggerFactory.getLogger(BrokerResponse.class);
+ static final EnumSet<QueryErrorCode> SYSTEM_ERROR_CODES = EnumSet.of(
Review Comment:
QueryErrorCode has a field of `_httpResponseStatus`
Can we use this code to distinguish the user errors(4XX) and internal
errors(5XX)?
Introducing a new `SYSTEM_ERROR_CODES` will make it harder to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
