dang-stripe commented on issue #17465: URL: https://github.com/apache/pinot/issues/17465#issuecomment-3716888623
My initial thought was to remove the code that includes the server in routing again: https://github.com/cbalci/pinot/blob/dc636e14298ccff01297fd672d56e50ff89bdd7d/pinot-broker/src/main/java/org/apache/pinot/broker/routing/manager/BaseBrokerRoutingManager.java#L387-L390 since the failure detector can handle it when it successfully re-connects, but this means servers that come up healthy will have to wait for the exponential backoff on the failure detector to expire before receiving queries. Instead, I'm currently testing a fix to recreate the DispatchClient which will recreate the ManagedChannel when a server is re-enabled. This will effectively clear any reconnection state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
