mcvsubbu commented on issue #4741: Make the download url of a realtime LLC segment as a list of urls. URL: https://github.com/apache/incubator-pinot/pull/4741#issuecomment-546098055 @chenboat we briefly discussed this approach proposed by @Jackie-Jiang and it does have advantages in terms of keeping segment metadata update to one entity (something we had discussed when the proposal was first brought up). It is worth thinking through one more level, and make sure that it satisfies the needs of the project. Note that we can still make the metadata field a list, just that servers are not there in the list. It also does not prevent a PR from changing the server to provide an endpoint to download a segment. Can you give it some thought? One thing that I am not very clear about is any race conditions: - Are there any subtle situations where while transitioning from CONSUMING to ONLINE it is possible that the server with the segment is not yet available in externalview? Can retries solve the problem or do we need more things to work around this? - Are there similar race conditions during rebalance or while moving completed segments to a different set of servers? At any rate, it will be good if you can capture the idea in the design doc, thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
