dang-stripe commented on code in PR #17466:
URL: https://github.com/apache/pinot/pull/17466#discussion_r2671157470
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -414,11 +414,16 @@ public void start()
// multi-stage request handler uses both Netty and GRPC ports.
// worker requires both the "Netty port" for protocol transport; and
"GRPC port" for mailbox transport.
// TODO: decouple protocol and engine selection.
+ // This query dispatcher is only used by the time-series request
handler. The multi-stage request handler creates
+ // it's own query dispatcher.
queryDispatcher = createQueryDispatcher(_brokerConf);
multiStageBrokerRequestHandler =
new MultiStageBrokerRequestHandler(_brokerConf, brokerId,
requestIdGenerator, _routingManager,
_accessControlFactory, _queryQuotaManager, _tableCache,
_multiStageQueryThrottler, _failureDetector,
_threadAccountant, multiClusterRoutingContext);
+ MultiStageBrokerRequestHandler finalHandler =
multiStageBrokerRequestHandler;
+ _routingManager.setServerReenableCallback(
Review Comment:
i decided to leave it for now. the constructor for
`MultiStageBrokerRequestHandler` takes in a `RoutingManager`. this was
previously was `BrokerRoutingManager` but changed in
https://github.com/apache/pinot/pull/16442. i could change it back, but seems
to be intentional. cc @shauryachats if there's more context there.
alternatively, we could add `setServerReenableCallback` to the
`RoutingManager` interface, but it's pretty specific to
`BaseBrokerRoutingManager` which processes server changes. the only other class
that implements `RoutingManager` is
https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/routing/manager/MultiClusterRoutingManager.java
which doesn't handle those today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
