ankitsultana commented on code in PR #17464:
URL: https://github.com/apache/pinot/pull/17464#discussion_r2673166899
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java:
##########
@@ -149,17 +156,22 @@ public TimeSeriesBlock handleTimeSeriesRequest(String
lang, String rawQueryParam
timeSeriesBlock =
_queryDispatcher.submitAndGet(requestContext.getRequestId(), dispatchablePlan,
timeSeriesRequest.getTimeout().toMillis(), requestContext);
+ TimeSeriesResponseMapper.setStatsInRequestContext(requestContext,
timeSeriesBlock.getMetadata());
return timeSeriesBlock;
} catch (Exception e) {
+ QueryException qe;
Review Comment:
Hmm errors can also be in timeSeriesBlock right with your recent changes?
Those should also be propagated to the event listener
##########
pinot-timeseries/pinot-timeseries-planner/src/main/java/org/apache/pinot/tsdb/planner/physical/TableScanVisitor.java:
##########
@@ -86,19 +87,20 @@ public void assignSegmentsToPlan(BaseTimeSeriesPlanNode
planNode, TimeBuckets ti
* @param planNode The {@link BaseTimeSeriesPlanNode} to process.
* @return The updated {@link BaseTimeSeriesPlanNode} with table type
information.
*/
- public BaseTimeSeriesPlanNode addTableTypeInfoToPlan(BaseTimeSeriesPlanNode
planNode) {
+ public BaseTimeSeriesPlanNode addTableTypeInfoToPlan(BaseTimeSeriesPlanNode
planNode, RequestContext requestContext) {
if (planNode instanceof LeafTimeSeriesPlanNode) {
LeafTimeSeriesPlanNode sfpNode = (LeafTimeSeriesPlanNode) planNode;
TableRouteInfo routeInfo =
_tableRouteProvider.getTableRouteInfo(sfpNode.getTableName(), _tableCache,
_routingManager);
String tableNameWithType = getTableNameWithType(routeInfo);
Preconditions.checkNotNull(tableNameWithType, "Table not found for table
name: " + sfpNode.getTableName());
+ requestContext.setTableName(tableNameWithType);
Review Comment:
can you create a separate dfs function for this? doing multiple unrelated
things in the same code leads to spaghetti over time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
