mcvsubbu commented on a change in pull request #4728: Optimizations for
IndexedTable resize
URL: https://github.com/apache/incubator-pinot/pull/4728#discussion_r338840481
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/IndexedTable.java
##########
@@ -33,43 +32,44 @@
*/
public abstract class IndexedTable implements Table {
- List<AggregationFunction> _aggregationFunctions;
+ AggregationFunction[] _aggregationFunctions;
int _numAggregations;
DataSchema _dataSchema;
+ int _capacity;
Review comment:
A comment on what the difference is between 'capacity' and 'maxCapacity'
will be nice. If I get it right, capacity is the number we need to trim to (at
most) and maxCapacity is how high we are going to go in order to not drop new
keys coming in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
