anuragrai16 commented on code in PR #17380:
URL: https://github.com/apache/pinot/pull/17380#discussion_r2684910352
##########
pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadataUtils.java:
##########
@@ -94,6 +94,8 @@ private static void updateSegmentZKMetadata(String
tableNameWithType, SegmentZKM
segmentZKMetadata.setEndOffset(endOffset);
segmentZKMetadata.setStatus(CommonConstants.Segment.Realtime.Status.DONE);
+ // for committing segments, we use data CRC for replace
+ segmentZKMetadata.setUseDataCrcForReplace(true);
Review Comment:
Good point,
- added flag set only if data crc exists for the segment
- setting flag to false for refresh segments flows when endOffset is NULL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
