yashmayya commented on code in PR #17215:
URL: https://github.com/apache/pinot/pull/17215#discussion_r2695345907
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -245,6 +247,32 @@ static SortedMap<String, String>
convertToSortedMap(Map<String, String> map) {
}
}
+ /// Returns a map from server instance to replica group ID, generated from
the ideal state instance partitions
+ /// metadata.
+ static Map<String, Integer> serverToReplicaGroupMap(IdealState idealState) {
Review Comment:
When the feature is disabled, the ideal state list fields will be empty and
this step will basically be a no-op. I'd prefer to keep it as is for simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
