Jackie-Jiang commented on code in PR #17503:
URL: https://github.com/apache/pinot/pull/17503#discussion_r2697212995
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -746,12 +747,11 @@ void
revertSegmentUpsertMetadataWithRetry(ImmutableSegment segment, ThreadSafeMu
}
}
- protected abstract void removeNewlyAddedKeys(IndexSegment oldSegment);
-
protected abstract void eraseKeyToPreviousLocationMap();
Review Comment:
During the segment replacement, we should clear the keys one by one as the
record is switched to point to the sealed segment. After replacement, the
remaining keys should be reverted. We shouldn't need to explicitly clear the
map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
