Jackie-Jiang commented on code in PR #17522:
URL: https://github.com/apache/pinot/pull/17522#discussion_r2709773584
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/user/UserConfig.java:
##########
@@ -109,10 +109,18 @@ public List<String> getExcludeTables() {
}
@JsonProperty(PERMISSIONS_KEY)
- public List<AccessType> getPermissios() {
+ public List<AccessType> getPermissions() {
return _permissions;
}
+ /**
+ * @deprecated Use {@link #getPermissions()} instead. This method has a typo
in its name.
+ */
+ @Deprecated
+ public List<AccessType> getPermissios() {
Review Comment:
I think we'll need to add `@JsonIgnore` to this method. Same for
`getUsernameWithComponent()` (not introduced in this PR).
Could you please also add a test to ensure the serialized format is as
expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
