Jackie-Jiang commented on code in PR #17550:
URL: https://github.com/apache/pinot/pull/17550#discussion_r2718873739
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertContext.java:
##########
@@ -131,14 +132,18 @@ public String getDeleteRecordColumn() {
}
public boolean isDropOutOfOrderRecord() {
- return _dropOutOfOrderRecord;
+ return _dropOutOfOrderRecord && _consistencyMode ==
UpsertConfig.ConsistencyMode.NONE;
Review Comment:
We don't need to change this. It is already handled properly in the builder
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertContext.java:
##########
@@ -64,7 +65,7 @@ public class UpsertContext {
@Nullable
private final TableDataManager _tableDataManager;
private final File _tableIndexDir;
-
+ private static final Logger LOGGER =
org.slf4j.LoggerFactory.getLogger(UpsertContext.class);
Review Comment:
Move this up next to the class definition, and also import
`org.slf4j.LoggerFactory`
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
Review Comment:
Also update the comment
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertContext.java:
##########
@@ -131,14 +132,18 @@ public String getDeleteRecordColumn() {
}
public boolean isDropOutOfOrderRecord() {
- return _dropOutOfOrderRecord;
+ return _dropOutOfOrderRecord && _consistencyMode ==
UpsertConfig.ConsistencyMode.NONE;
}
@Nullable
public String getOutOfOrderRecordColumn() {
return _outOfOrderRecordColumn;
}
+ public boolean isOutOfOrderRecordColumn() {
Review Comment:
We don't need this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
