xiangfu0 opened a new pull request, #17652: URL: https://github.com/apache/pinot/pull/17652
## Problem `PinotTableRestletResourceTest#testTableTasksCleanupWithNonActiveTasks` was flaky because it resumed the minion task queue before table deletion completed. That can race with task cleanup and intermittently fail with: `Failed to delete job ... from queue ...` ## Change - Keep the task queue stopped while deleting the table in `testTableTasksCleanupWithNonActiveTasks` - Resume the queue in a `finally` block so test cleanup is guaranteed ## Why this fixes flakiness Holding the queue stopped through deletion removes the window where Helix task transitions can recreate/remove task metadata concurrently with cleanup. ## Validation - `./mvnw -pl pinot-controller -Dtest=PinotTableRestletResourceTest#testTableTasksCleanupWithNonActiveTasks -Dsurefire.failIfNoSpecifiedTests=false test -DskipITs -DskipIntegrationTests` - Repeated runs of the same test (9 consecutive successful loop iterations + 1 additional pass) - `./mvnw -pl pinot-controller -Dtest=PinotTableRestletResourceTest#testTableTasksCleanupWithActiveTasks -Dsurefire.failIfNoSpecifiedTests=false test -DskipITs -DskipIntegrationTests` - `./mvnw -pl pinot-controller -Dtest=PinotTableRestletResourceTest -Dsurefire.failIfNoSpecifiedTests=false test -DskipITs -DskipIntegrationTests` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
