justahuman1 commented on issue #17362: URL: https://github.com/apache/pinot/issues/17362#issuecomment-3865485364
Hmm, I was taking a look and noticed the implementation in #17428 addresses the issue in cases of large indexes or large negative indexes since it accumulates the entries in an list via `substrings.add(str.substring(beg, end));` I sent out #17660 which addresses this and addresses the comments from @Jackie-Jiang as well. I also extended the coverage with missing tests and added JMH benchmarking. The perf is >10x in some cases and just barely slower in uncommon cases 😄 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
