ilamhs opened a new pull request, #17675:
URL: https://github.com/apache/pinot/pull/17675
The default segment fetcher for HTTPS protocol incorrectly returns
HttpSegmentFetcher instead of HttpsSegmentFetcher. This means SSL configuration
options in HttpsSegmentFetcher (including the renewable SSL context added in
#17315) are never used for default HTTPS fetches.
This change:
- Adds a dedicated HTTPS_SEGMENT_FETCHER instance
- Initializes it alongside other default fetchers
- Returns it for HTTPS protocol in getSegmentFetcher()
- Updates javadoc and test to reflect correct behavior
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `release-notes` (**)
2. Remove these instructions before publishing the PR.
(*) Other labels to consider:
- `testing`
- `dependencies`
- `docker`
- `kubernetes`
- `observability`
- `security`
- `code-style`
- `extension-point`
- `refactor`
- `cleanup`
(**) Use `release-notes` label for scenarios like:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
