gortiz commented on code in PR #17674:
URL: https://github.com/apache/pinot/pull/17674#discussion_r2792326041
##########
pom.xml:
##########
@@ -2929,6 +2929,9 @@
<!-- Solve NoClassDefFoundError. Borrowed from
https://github.com/prometheus/jmx_exporter/issues/802 -->
<exclude>META-INF/versions/9/org/yaml/snakeyaml/internal/**</exclude>
+
+ <!-- Exclude NettyInstacne because it includes Netty package
literals -->
Review Comment:
This is as fragile as the other exclusions, right?
Anyway, I'm going to modify the PR because I'm wrong. I was sure we were
shading Netty, but we don't do that, so we are double-safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
