ilamhs commented on code in PR #14414: URL: https://github.com/apache/pinot/pull/14414#discussion_r2795443709
########## pinot-controller/src/main/java/org/apache/pinot/controller/api/access/GrizzlyRequestAdapter.java: ########## @@ -0,0 +1,95 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.api.access; + +import java.lang.reflect.Proxy; +import java.util.Collections; +import java.util.Enumeration; +import javax.annotation.Nullable; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletRequestWrapper; +import org.glassfish.grizzly.http.server.Request; + + +public final class GrizzlyRequestAdapter extends HttpServletRequestWrapper { + private final Request _grizzlyRequest; + + private GrizzlyRequestAdapter(Request grizzlyRequest) { Review Comment: This is something I can take an opinion on. This change is not in the Pinot SPI but only Pinot API for different components. For Request: * `javax.servlet.http.HttpServletRequest` is the interface * `org.glassfish.grizzly.http.server.Request` is the implementation of it in Pinot. The question is, do we care about it being the interface or ok with the Grizzly request on the API. I see that Grizzly impl is tightly coupled in Pinot codebase right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
