Jackie-Jiang commented on code in PR #17602:
URL: https://github.com/apache/pinot/pull/17602#discussion_r2806826430
##########
pom.xml:
##########
@@ -2802,6 +2796,9 @@
<!-- Spark datasource register -->
<exclude>**/org.apache.spark.sql.sources.DataSourceRegister</exclude>
+ <!-- StreamConsumerFactory register -->
+
<exclude>**/org.apache.pinot.spi.stream.StreamConsumerFactory</exclude>
Review Comment:
Is this intentional?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##########
@@ -96,8 +96,11 @@ public class PluginManager {
// StreamConsumerFactory
// Old-style class names mapped to current plugin packages
+ // Rename the usage of kafka 2 to kafka 3
Review Comment:
Will this cause problem? Or should we just throw exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
