ankitsultana commented on code in PR #17676:
URL: https://github.com/apache/pinot/pull/17676#discussion_r2807042998
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java:
##########
@@ -166,6 +167,9 @@ public TimeSeriesBlock handleTimeSeriesRequest(String lang,
String rawQueryParam
timeSeriesBlock =
_queryDispatcher.submitAndGet(requestContext.getRequestId(), dispatchablePlan,
timeSeriesRequest.getTimeout().toMillis(), requestContext);
+
+ long endToEndTimeMs = System.currentTimeMillis() - queryStartTime;
Review Comment:
We should return time for every case. There are some if conditions like on
L161 which will miss this.
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/TimeSeriesExchangeReceiveOperator.java:
##########
@@ -210,6 +218,21 @@ private void mergeStats(Map<String, String>
aggregatedStats, Map<String, String>
}
}
}
+
+ for (DataTable.MetadataKey statKey : MIN_STATS_KEYS) {
+ String key = statKey.getName();
+ String existingValue = aggregatedStats.getOrDefault(key, "0");
Review Comment:
Doesn't this mean that the result will always be 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
