krishan1390 commented on code in PR #17697:
URL: https://github.com/apache/pinot/pull/17697#discussion_r2820470274
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -1213,18 +1229,20 @@ public void testBetween()
assertNoError(jsonNode);
assertEquals(jsonNode.get("resultTable").get("rows").get(0).get(0).asInt(),
58538);
- explainQuery =
- "SET " +
CommonConstants.Broker.Request.QueryOptionKey.EXPLAIN_ASKING_SERVERS + "=true;
EXPLAIN PLAN FOR "
- + sqlQuery;
- jsonNode = postQuery(explainQuery);
- assertNoError(jsonNode);
- plan = jsonNode.get("resultTable").get("rows").get(0).get(1).asText();
- // Ensure that the BETWEEN filter predicate was not converted. Also ensure
that the NOT filter is added.
- Assert.assertTrue(plan.contains("BETWEEN"));
- Assert.assertTrue(plan.contains("FilterNot"));
- Assert.assertFalse(plan.contains(">="));
- Assert.assertFalse(plan.contains("<="));
- Assert.assertFalse(plan.contains("Sarg"));
+ if (testExplainPlanForNotBetween) {
Review Comment:
Yes this is the only case. other explain assertions work fine. I don't yet
know the cause as I haven't debugged yet. Will do that soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
