yashmayya commented on PR #17751: URL: https://github.com/apache/pinot/pull/17751#issuecomment-3948100812
Do you mean to move it out of the `compileRequest` method and only add it in the various branches (hybrid, realtime only, offline only) in `doHandleRequest`? I think there will be a few more paths it will need to be applied in to make sure that the broker / server requests aren't created from different queries [here](https://github.com/apache/pinot/blob/9de73ec47cb50ffbc09efa6d454a9db7eb0abdc2/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java#L441-L444) (and possibly other places too). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
