jihaozh commented on a change in pull request #4748: [TE][notification] Ability to reopen and reuse existing Jira tickets for alerts URL: https://github.com/apache/incubator-pinot/pull/4748#discussion_r340307085
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/notification/commons/JiraEntity.java ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.thirdeye.notification.commons; + +import java.util.List; + + +/** + * ThirdEye's Jira Settings Holder + */ +public class JiraEntity { + private String jiraProject; + private Long jiraIssueTypeId; + private String summary; + private String description; + private String assignee; + private List<String> labels; + private long mergeGap; Review comment: Instead of being part of the `JiraEntity`, shouldn't the `mergeGap` be part of the config like the merger we are using in detection?. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
