jineshparakh opened a new pull request, #17768:
URL: https://github.com/apache/pinot/pull/17768
## Summary
- Add `tasksTrackedForTaskType` to the existing task-type regex pattern in
`controller.yml` so the `TASKS_TRACKED_FOR_TASK_TYPE` gauge (introduced in
#17741) is exported as
`pinot_controller_tasksTrackedForTaskType_Value{taskType="..."}`.
- Add corresponding test coverage in `ControllerPrometheusMetricsTest` to
verify the gauge is exported with the correct `taskType` label.
## Test plan
- [x] `YammerControllerPrometheusMetricsTest` passes with the new assertion
for `TASKS_TRACKED_FOR_TASK_TYPE`
- [x] Manually verified with local QuickStart + JMX Prometheus agent that
`pinot_controller_tasksTrackedForTaskType_Value{taskType="HelloWorld"}`
appears at `localhost:9021/metrics` after scheduling a task
```
❯ curl -s http://localhost:9021/metrics | grep -i tasksTrackedForTaskType
# HELP pinot_controller_tasksTrackedForTaskType_Value Attribute exposed for
management
"org.apache.pinot.common.metrics":name="pinot.controller.tasksTrackedForTaskType.MergeRollupTask",type="ControllerMetrics",attribute=Value
# TYPE pinot_controller_tasksTrackedForTaskType_Value untyped
pinot_controller_tasksTrackedForTaskType_Value{taskType="MergeRollupTask",}
1.0
pinot_controller_tasksTrackedForTaskType_Value{taskType="RealtimeToOfflineSegmentsTask",}
2.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
