shauryachats commented on code in PR #17761:
URL: https://github.com/apache/pinot/pull/17761#discussion_r2854683604
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2198,6 +2197,21 @@ public void updateLogicalTableConfig(LogicalTableConfig
logicalTableConfig)
LOGGER.info("Updated logical table {}: Successfully updated table",
tableName);
}
+ public void validatePhysicalTablesExist(LogicalTableConfig
logicalTableConfig) {
+ for (Map.Entry<String, PhysicalTableConfig> entry :
logicalTableConfig.getPhysicalTableConfigMap().entrySet()) {
+ PhysicalTableConfig physicalTableConfig = entry.getValue();
+ String physicalTableName = entry.getKey();
+ // Skip existence validation for multi-cluster physical tables
+ if (!physicalTableConfig.isMultiCluster()) {
Review Comment:
nit: We can also add a INFO log for "Physical table {} is multi cluster,
skipping existence check" for more info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
