This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4a093679f89 Add Prometheus export rule for tasksTrackedForTaskType
(#17768)
4a093679f89 is described below
commit 4a093679f89636185d84e4f5640532433fa87ef2
Author: Jinesh Parakh <[email protected]>
AuthorDate: Thu Feb 26 09:13:14 2026 +0530
Add Prometheus export rule for tasksTrackedForTaskType (#17768)
---
.../images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml | 2 +-
.../common/metrics/prometheus/ControllerPrometheusMetricsTest.java | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git
a/docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml
b/docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml
index 4b06ad572ec..7ea45e7f6e5 100644
--- a/docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml
+++ b/docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml
@@ -17,7 +17,7 @@ rules:
tableType: "$6"
partition: "$7"
# Gauges that accept the controller taskType
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.(numMinionTasksInProgress|numMinionSubtasksRunning|numMinionSubtasksWaiting|numMinionSubtasksError|numMinionSubtasksUnknown|numMinionSubtasksDropped|numMinionSubtasksTimedOut|numMinionSubtasksAborted|percentMinionSubtasksInQueue|percentMinionSubtasksInError)\\.(\\w+)\"><>(\\w+)"
+- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ControllerMetrics\",
name=\"pinot\\.controller\\.(numMinionTasksInProgress|numMinionSubtasksRunning|numMinionSubtasksWaiting|numMinionSubtasksError|numMinionSubtasksUnknown|numMinionSubtasksDropped|numMinionSubtasksTimedOut|numMinionSubtasksAborted|percentMinionSubtasksInQueue|percentMinionSubtasksInError|tasksTrackedForTaskType)\\.(\\w+)\"><>(\\w+)"
name: "pinot_controller_$1_$3"
cache: true
labels:
diff --git
a/pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java
b/pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java
index 45583184d41..381f0d2c69e 100644
---
a/pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java
+++
b/pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/ControllerPrometheusMetricsTest.java
@@ -178,6 +178,10 @@ public abstract class ControllerPrometheusMetricsTest
extends PinotPrometheusMet
String.format("%s.%s",
ExportedLabelValues.CONTROLLER_PERIODIC_TASK_CHC, TaskState.IN_PROGRESS));
assertGaugeExportedCorrectly(ControllerGauge.TASK_STATUS.getGaugeName(),
ExportedLabels.JOBSTATUS_CONTROLLER_TASKTYPE,
EXPORTED_METRIC_PREFIX);
+ } else if (controllerGauge ==
ControllerGauge.TASKS_TRACKED_FOR_TASK_TYPE) {
+ addGaugeWithLabels(controllerGauge,
ExportedLabelValues.CONTROLLER_PERIODIC_TASK_CHC);
+ assertGaugeExportedCorrectly(controllerGauge.getGaugeName(),
+ List.of(LABEL_KEY_TASK_TYPE,
ExportedLabelValues.CONTROLLER_PERIODIC_TASK_CHC), EXPORTED_METRIC_PREFIX);
} else {
addGaugeWithLabels(controllerGauge, TABLE_NAME_WITH_TYPE);
assertGaugeExportedCorrectly(controllerGauge.getGaugeName(),
ExportedLabels.TABLENAME_TABLETYPE,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
