sekikn opened a new pull request #4756: Use normal Logger rather than AsyncLogger for pinot-admin's console log URL: https://github.com/apache/incubator-pinot/pull/4756 I tried some pinot-admin subcommands and noticed that it sometimes exited before the error messages were displayed. I think it misleads users and makes difficult for them to understand what's happened. ``` # With AsyncLogger ~/repos/incubator-pinot/pinot-distribution/target/apache-pinot-incubating-0.2.0-SNAPSHOT-bin/apache-pinot-incubating-0.2.0-SNAPSHOT-bin$ JAVA_OPTS="-Dpinot.admin.system.exit=true" bin/pinot-admin.sh GenerateData ~/repos/incubator-pinot/pinot-distribution/target/apache-pinot-incubating-0.2.0-SNAPSHOT-bin/apache-pinot-incubating-0.2.0-SNAPSHOT-bin$ echo $? 1 # With Logger ~/repos/incubator-pinot/pinot-distribution/target/apache-pinot-incubating-0.2.0-SNAPSHOT-bin/apache-pinot-incubating-0.2.0-SNAPSHOT-bin$ JAVA_OPTS="-Dpinot.admin.system.exit=true" bin/pinot-admin.sh GenerateData 08:01:52.904 PinotAdministrator - Error: Option "-numFiles" is required ~/repos/incubator-pinot/pinot-distribution/target/apache-pinot-incubating-0.2.0-SNAPSHOT-bin/apache-pinot-incubating-0.2.0-SNAPSHOT-bin$ echo $? 1 ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
