Jackie-Jiang commented on code in PR #17827:
URL: https://github.com/apache/pinot/pull/17827#discussion_r2894475936
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2158,16 +2158,6 @@ public void updateUserConfig(UserConfig userConfig)
AccessControlUserConfigUtils.toZNRecord(userConfig));
}
- /**
- * Validate the table config and update it
- * @throws IOException
- * @throws TableConfigBackwardIncompatibleException if config changes are
backward incompatible
- */
- public void updateTableConfig(TableConfig tableConfig)
Review Comment:
I feel this method is more concise. Alternatively we can make it `final` to
prevent wrong override. Directly removing it is backward incompatible
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
Review Comment:
Seems it won't throw `IOException` as well. Let's clean it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
