Jackie-Jiang commented on code in PR #17789:
URL: https://github.com/apache/pinot/pull/17789#discussion_r2897569126
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -786,9 +786,10 @@ static void validateUpsertAndDedupConfig(TableConfig
tableConfig, Schema schema)
// check both upsert and dedup are not enabled simultaneously
Preconditions.checkState(!(isUpsertEnabled && isDedupEnabled),
"A table can have either Upsert or Dedup enabled, but not both");
- // check table type is realtime
- Preconditions.checkState(tableConfig.getTableType() == TableType.REALTIME,
- "Upsert/Dedup table is for realtime table only.");
+ // check table type is realtime or offline
Review Comment:
Remove this check lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
