xiangfu0 commented on code in PR #17811:
URL: https://github.com/apache/pinot/pull/17811#discussion_r2897665658
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -400,7 +398,8 @@ public void setUpNewTable(TableConfig tableConfig,
IdealState idealState,
List<StreamConfig> streamConfigs =
IngestionConfigUtils.getStreamConfigs(tableConfig);
Review Comment:
Addressed. In `setUpNewTable(..., List<StreamMetadata>)` we now reuse
`streamMetadata.getStreamConfig()` directly and no longer recompute
`IngestionConfigUtils.getStreamConfigs(tableConfig)`. The same loop also
accumulates `numPartitionGroups`.
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMetadata.java:
##########
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.stream;
+
+import java.util.List;
+
+
+/**
+ * Groups partition metadata for a single stream/topic.
+ *
+ * <p>This replaces the flat {@code List<PartitionGroupMetadata>} pattern
where partitions from all streams were mixed
+ * together and required partition ID padding to identify stream membership.
+ *
+ * <p>The {@link PartitionGroupMetadata} items within this container use
Pinot-encoded partition IDs
+ * (i.e., {@code streamIndex * 10000 + streamPartitionId}) to maintain
backward compatibility with segment names
+ * stored in ZooKeeper.
+ */
+public class StreamMetadata {
Review Comment:
I considered `StreamContext`. I kept `StreamMetadata` because this type is
primarily a data container for stream partition metadata + partition count, and
it is produced/consumed directly by metadata-fetch paths. Renaming to
`StreamContext` would add broad churn without changing behavior; happy to do it
in a follow-up if we want that naming convention repo-wide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
