Copilot commented on code in PR #17659:
URL: https://github.com/apache/pinot/pull/17659#discussion_r2898136510
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/ArrayTest.java:
##########
@@ -727,6 +728,63 @@ public void testArraysOverlapWithSameColumn(boolean
useMultiStageQueryEngine)
assertEquals(jsonNode.get("resultTable").get("rows").get(0).get(0).asLong(),
getCountStarResult());
}
+ @Test(dataProvider = "useBothQueryEngines")
+ public void testFilterMvLongArrayFilterValues(boolean
useMultiStageQueryEngine)
+ throws Exception {
+ setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+ String query = String.format("SELECT filterMv(%s, 'v > 1') FROM %s WHERE
%s = 0 LIMIT 1", LONG_ARRAY_COLUMN,
+ getTableName(), INT_COLUMN);
+ JsonNode result = postQuery(query).get("resultTable");
Review Comment:
The new integration coverage validates `filterMv()` for LONG_ARRAY and
STRING_ARRAY, but it doesn’t exercise BOOLEAN_ARRAY (important for the
multi-stage engine where execution goes through FunctionRegistry/UDF paths).
Adding an assertion like `filterMv(booleanArrayCol, 'v = true')` (both value
filtering and `arrayLength(...)` in a WHERE clause) would help catch
BOOLEAN_ARRAY type-conversion issues early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
