davecromberge commented on code in PR #17825:
URL: https://github.com/apache/pinot/pull/17825#discussion_r2911104025
##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -133,6 +133,15 @@ public static abstract class MergeTask {
public static final String MAX_NUM_RECORDS_PER_TASK_KEY =
"maxNumRecordsPerTask";
public static final String MAX_NUM_RECORDS_PER_SEGMENT_KEY =
"maxNumRecordsPerSegment";
+ // Reducer config
+ /**
+ * Maximum number of rows to batch before aggregating during rollup reduce
phase.
+ * Higher values improve performance for sketch aggregations but use more
memory.
+ * Default is 1000.
+ */
+ public static final String REDUCER_MAX_BATCH_SIZE_KEY =
"reducerMaxBatchSize";
+ public static final int DEFAULT_REDUCER_MAX_BATCH_SIZE = 1000;
+
Review Comment:
Updated description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]