suvodeep-pyne opened a new pull request, #17854:
URL: https://github.com/apache/pinot/pull/17854

   ## Summary
   - Adds a `closeFuture` listener in `QueryServer.initChannel()` to remove 
channels from `_allChannels` when they close, preventing indefinite 
accumulation of closed channel references (memory leak)
   - Adds `@VisibleForTesting getConnectedChannelCount()` getter for test access
   - Adds `testAllChannelsCleanupOnClose` test validating channels are cleaned 
up on close
   
   ## Test plan
   - [x] `QueryServerTest#testAllChannelsCleanupOnClose` — connects a socket, 
asserts channel registered, closes socket, asserts channel removed
   - [ ] Run full `QueryServerTest`: `mvn -pl pinot-core test 
-Dtest=QueryServerTest -Drat.skip=true -Dcheckstyle.skip=true`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to