xiangfu0 opened a new pull request, #17855: URL: https://github.com/apache/pinot/pull/17855
## Summary - Ensure Kafka starts after Zookeeper but before Controller across all integration tests (startup: ZK → Kafka → Controller → Broker → Server) - Ensure Kafka stops after Controller but before Zookeeper in teardown (teardown: Server → Broker → Controller → Kafka → ZK) - Add missing `@AfterClass` tearDown methods with `stopKafka()` to 5 tests that were starting Kafka but never stopping it ## Files changed **Startup ordering fixes** (10 files — moved `startKafka()` before `startController()`): - `BaseRealtimeClusterIntegrationTest.java` - `CLPEncodingRealtimeIntegrationTest.java` - `QueryWorkloadIntegrationTest.java` - `RetentionManagerIntegrationTest.java` - `StaleSegmentCheckIntegrationTest.java` - `PinotSinkUpsertTableIntegrationTest.java` - `PartialUpsertTableRebalanceIntegrationTest.java` - `NullHandlingIntegrationTest.java` - `PauselessRealtimeIngestionSegmentCommitFailureTest.java` - `BasePauselessRealtimeIngestionTest.java` **Teardown ordering fixes** (3 files — moved `stopKafka()` after `stopController()`): - `BrokerQueryLimitTest.java` - `CustomDataQueryClusterIntegrationTest.java` - `BaseLogicalTableIntegrationTest.java` **Added missing tearDown with `stopKafka()`** (5 files): - `CLPEncodingRealtimeIntegrationTest.java` — no tearDown at all - `QueryWorkloadIntegrationTest.java` — no tearDown at all - `RetentionManagerIntegrationTest.java` — no tearDown at all - `PinotSinkUpsertTableIntegrationTest.java` — no tearDown at all - `StaleSegmentCheckIntegrationTest.java` — tearDown existed but was missing `stopKafka()` ## Test plan - [ ] Verify existing integration tests still pass with the reordered startup/teardown - [ ] Confirm no Kafka-related resource leaks in CI 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
