KKcorps commented on code in PR #17847:
URL: https://github.com/apache/pinot/pull/17847#discussion_r2929516140
##########
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java:
##########
@@ -474,6 +476,40 @@ public List<FileMetadata> listFilesWithMetadata(URI
fileUri, boolean recursive)
}
}
+ @Override
+ public List<FileMetadata> listFilesWithMetadata(final URI fileUri, final
boolean recursive,
+ final Predicate<String> pathFilter, final int maxResults)
+ throws IOException {
+ LOGGER.debug("listFilesWithMetadata (paginated) is called with
fileUri='{}', recursive='{}', maxResults={}",
Review Comment:
if maxResults <= 0, we should return immediately with a warning. Just a
sanity check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
