icefury71 commented on issue #4525: Pinot server replacement in Cloud where we 
have no control over hostname
URL: 
https://github.com/apache/incubator-pinot/issues/4525#issuecomment-548088007
 
 
   @kishoreg thinking more about PR (1):
   
   A performance side effect of decoupling is that every single reference to 
instance name will result in a Zk call (naive implementation). I'm guessing 
this is why the instance name was constructed with this information in the 
first place (which is a nice hack).
   
   For a clean design, how about we create a helper class which caches the map 
of instance name to <host,port> info ? We can implement a Helix spectator to 
keep this map updated. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to