xiaohui-sun commented on a change in pull request #4763: [TE] endpoints -
harleyjj/alert-activation - make endpoint for toggli…
URL: https://github.com/apache/incubator-pinot/pull/4763#discussion_r341317576
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java
##########
@@ -540,6 +541,41 @@ public Response createUserAnomaly(
return Response.ok(anomaly.getId()).build();
}
+ /**
+ * Toggle active/inactive for given detection
+ *
+ * @param detectionId detection config id (must exist)
+ */
+ @PUT
+ @Path("/activation/{id}")
Review comment:
Can we explicitly setting active/inactive?
By using toggle() users need to know whether it is active/in-active first
which is an extra work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
