bxji commented on a change in pull request #4761: [TE] Centralized cache proof-of-concept for anomaly detection via Couchbase URL: https://github.com/apache/incubator-pinot/pull/4761#discussion_r341385211
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/cache/ThirdEyeCacheResponse.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.thirdeye.detection.cache; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import org.apache.pinot.thirdeye.datasource.MetricFunction; +import org.apache.pinot.thirdeye.datasource.ThirdEyeResponse; +import org.apache.pinot.thirdeye.rootcause.impl.MetricEntity; + +public class ThirdEyeCacheResponse { + private final ThirdEyeCacheRequest request; + private List<TimeSeriesDataPoint> rows; + + public ThirdEyeCacheResponse(ThirdEyeCacheRequest request, List<TimeSeriesDataPoint> rows) { + this.request = request; + this.rows = rows; + } + + public ThirdEyeCacheRequest getCacheRequest() { return request; } + public List<TimeSeriesDataPoint> getRows() { return rows; } + + public int getNumRows() { return rows.size(); } + public boolean hasNoRows() { return rows.isEmpty(); } + public long getFirstTimestamp() { return rows.get(0).getTimestamp(); } + public long getLastTimestamp() { return rows.get(rows.size() - 1).getTimestamp(); } + + public boolean isMissingSlice(long sliceStart, long sliceEnd) { + return isMissingStartSlice(sliceStart) || isMissingEndSlice(sliceEnd); + } + + public boolean isMissingStartSlice(long sliceStart) { + if (this.hasNoRows()) { + return true; + } + long timeGranularity = request.getRequest().getGroupByTimeGranularity().toMillis(); + return sliceStart <= getFirstTimestamp() - timeGranularity; + } + + public boolean isMissingEndSlice(long sliceEnd) { + if (this.hasNoRows()) { + return true; + } + + // note: sliceEnd is exclusive so we don't need equality check. + long timeGranularity = request.getRequest().getGroupByTimeGranularity().toMillis(); + return sliceEnd > getLastTimestamp() + timeGranularity; + } + + public void mergeSliceIntoRows(ThirdEyeResponse slice, MergeSliceType type) { Review comment: yes, my bad. It's an old approach I was trying out that I forgot to rework. Will change this asap ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
