jihaozh commented on a change in pull request #4765: [TE] Clean up
ADContentFormatterContext
URL: https://github.com/apache/incubator-pinot/pull/4765#discussion_r341409326
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertTaskFactory.java
##########
@@ -103,8 +100,8 @@ public DetectionAlertFilter
loadAlertFilter(DetectionAlertConfigDTO alertConfig,
Preconditions.checkNotNull(alertSchemes.get(alertSchemeType));
Preconditions.checkNotNull(alertSchemes.get(alertSchemeType).get(PROP_CLASS_NAME));
Constructor<?> constructor =
Class.forName(alertSchemes.get(alertSchemeType).get(PROP_CLASS_NAME).toString().trim())
- .getConstructor(ADContentFormatterContext.class,
ThirdEyeAnomalyConfiguration.class, DetectionAlertFilterResult.class);
- detectionAlertSchemeSet.add((DetectionAlertScheme)
constructor.newInstance(adContext, thirdeyeConfig, result));
+ .getConstructor(DetectionAlertConfigDTO.class,
ThirdEyeAnomalyConfiguration.class, DetectionAlertFilterResult.class);
Review comment:
Will change the function signature break tests in "third eye-external"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
