xiangfu0 commented on code in PR #17998:
URL: https://github.com/apache/pinot/pull/17998#discussion_r3005974751
##########
.github/workflows/pinot_tests.yml:
##########
@@ -138,12 +138,19 @@ jobs:
for mod in pinot-spi pinot-segment-spi; do
OLD=$(ls master-head/$mod/target/$mod-*.jar | grep -v
'\-tests.jar' | head -1)
NEW=$(ls $mod/target/$mod-*.jar | grep -v '\-tests.jar' | head -1)
+ EXCLUDES=""
Review Comment:
Done. Removed the japicmp excludes — they are no longer in the branch.
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/QueryRunnerTest.java:
##########
@@ -323,11 +323,10 @@ protected Iterator<Object[]>
provideTestSqlWithExecutionException() {
// - predicate only functions:
testCases.add(new Object[]{"SELECT * FROM a WHERE textMatch(col1, 'f')",
"without text index"});
testCases.add(new Object[]{"SELECT * FROM a WHERE text_match(col1, 'f')",
"without text index"});
- testCases.add(new Object[]{"SELECT * FROM a WHERE textContains(col1,
'f')", "supported only on native text index"});
- testCases.add(new Object[]{
- "SELECT * FROM a WHERE text_contains(col1, 'f')",
- "supported only on native text index"}
- );
+ testCases.add(new Object[]{"SELECT * FROM a WHERE textContains(col1, 'f')",
+ "No match found for function signature"});
+ testCases.add(new Object[]{"SELECT * FROM a WHERE text_contains(col1,
'f')",
+ "No match found for function signature"});
Review Comment:
Done. Removed the `textContains`/`text_contains` test cases.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/fst/FSTBuilder.java:
##########
@@ -1,70 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.pinot.segment.local.utils.fst;
-
-import java.io.IOException;
-import java.util.Map;
-import java.util.SortedMap;
-import org.apache.lucene.util.IntsRefBuilder;
-import org.apache.lucene.util.fst.FST;
-import org.apache.lucene.util.fst.FSTCompiler;
-import org.apache.lucene.util.fst.PositiveIntOutputs;
-import org.apache.lucene.util.fst.Util;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-
-/**
- * Builds case-sensitive FST using lucene org.apache.lucene.util.fst.Builder
library. FSTBuilder requires all the
- * key/values be added in sorted order.
- */
-public class FSTBuilder {
Review Comment:
Done. Restored all Lucene FST helper classes in `utils/fst/` and reverted
the unnecessary refactoring of index creators/readers.
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FSTType.java:
##########
@@ -18,9 +18,27 @@
*/
package org.apache.pinot.spi.config.table;
+import com.fasterxml.jackson.annotation.JsonCreator;
+import java.util.Locale;
+import javax.annotation.Nullable;
+
/**
- * Type of FST to be used
+ * Type of FST to be used.
*/
public enum FSTType {
Review Comment:
Done. `FSTType` enum has been fully removed along with all references to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
