kishoreg commented on a change in pull request #4761: [TE] Centralized cache
proof-of-concept for anomaly detection via Couchbase
URL: https://github.com/apache/incubator-pinot/pull/4761#discussion_r341638608
##########
File path: thirdeye/thirdeye-pinot/pom.xml
##########
@@ -239,6 +239,12 @@
<artifactId>parsii</artifactId>
</dependency>
+ <dependency>
Review comment:
Its a bit pre-mature but not abstracting these right now will result in a
classpath nightmare. We are seeing this in Pinot and I feel its better to break
optional stuff into interface and implementation. And then move the
implementation to a separate module and load them at runtime. Once we have
this, it makes it easy to add multiple implementations. For e.g. we might use
some other system for caching.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
