bxji commented on a change in pull request #4761: [TE] Centralized cache
proof-of-concept for anomaly detection via Couchbase
URL: https://github.com/apache/incubator-pinot/pull/4761#discussion_r341780581
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/utils/ThirdeyeMetricsUtil.java
##########
@@ -110,6 +110,15 @@ public Integer value() {
public static final Counter datasourceExceptionCounter =
metricsRegistry.newCounter(ThirdeyeMetricsUtil.class,
"datasourceExceptionCounter");
+ public static final Counter couchbaseCallCounter =
Review comment:
I'm not sure how we can get current cache capacity, as this seems like a
metric that whoever is operating and maintaining the cluster should emit. Maybe
we can heartbeat the cluster every now and then and ask how it's doing, but I
would need to look more into this. Cache hit ratio and cache miss ratio should
be doable if we can get derived metrics (total cache hits in a day/total cache
calls in a day, total cache misses in a day/total cache calls in a day, etc.),
and I will also look into getting partial cache hit ratio.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
