codecov-commenter commented on PR #18102: URL: https://github.com/apache/pinot/pull/18102#issuecomment-4191558051
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18102?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.07080%` with `36 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 56.11%. Comparing base ([`36cdab4`](https://app.codecov.io/gh/apache/pinot/commit/36cdab4e44949f5455f96863fcc72c5b6eb56f2f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36a6c2b`](https://app.codecov.io/gh/apache/pinot/commit/36a6c2bcb34a67834d7064f7f81674ef4828392a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/18102?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ache/pinot/core/accounting/QueryMonitorConfig.java](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Faccounting%2FQueryMonitorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9hY2NvdW50aW5nL1F1ZXJ5TW9uaXRvckNvbmZpZy5qYXZh) | 66.66% | [10 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../pinot/core/query/killing/QueryKillingManager.java](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Fkilling%2FQueryKillingManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9raWxsaW5nL1F1ZXJ5S2lsbGluZ01hbmFnZXIuamF2YQ==) | 75.43% | [11 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...killing/strategy/ScanEntriesThresholdStrategy.java](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Fkilling%2Fstrategy%2FScanEntriesThresholdStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9raWxsaW5nL3N0cmF0ZWd5L1NjYW5FbnRyaWVzVGhyZXNob2xkU3RyYXRlZ3kuamF2YQ==) | 90.00% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/query/killing/CompositeQueryKillingStrategy.java](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Fkilling%2FCompositeQueryKillingStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9raWxsaW5nL0NvbXBvc2l0ZVF1ZXJ5S2lsbGluZ1N0cmF0ZWd5LmphdmE=) | 92.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pinot/core/query/killing/QueryKillingStrategy.java](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Fkilling%2FQueryKillingStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9raWxsaW5nL1F1ZXJ5S2lsbGluZ1N0cmF0ZWd5LmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/pinot/spi/config/table/QueryConfig.java](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&filepath=pinot-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fspi%2Fconfig%2Ftable%2FQueryConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1F1ZXJ5Q29uZmlnLmphdmE=) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (36cdab4) and HEAD (36a6c2b). Click for more details. > > <details><summary>HEAD has 32 uploads less than BASE</summary> > >| Flag | BASE (36cdab4) | HEAD (36a6c2b) | >|------|------|------| >|java-21|5|1| >|unittests1|2|1| >|unittests|4|1| >|temurin|9|1| >|java-11|4|0| >|unittests2|2|0| >|integration|5|0| >|integration2|1|0| >|integration1|2|0| >|custom-integration1|2|0| ></details> <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #18102 +/- ## ============================================ - Coverage 63.85% 56.11% -7.74% + Complexity 1573 778 -795 ============================================ Files 3167 2476 -691 Lines 192092 141606 -50486 Branches 29601 22768 -6833 ============================================ - Hits 122666 79468 -43198 + Misses 59774 55337 -4437 + Partials 9652 6801 -2851 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.11% <84.07%> (-7.69%)` | :arrow_down: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.11% <84.07%> (-7.74%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.11% <84.07%> (-7.74%)` | :arrow_down: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.11% <84.07%> (+0.05%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/18102?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
