xiangfu0 commented on code in PR #17167:
URL: https://github.com/apache/pinot/pull/17167#discussion_r3038970111
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PartialUpsertTableRebalanceIntegrationTest.java:
##########
@@ -447,16 +435,10 @@ protected void waitForReloadToComplete(String
reloadJobId, long timeoutMs)
throws Exception {
TestUtils.waitForCondition(aVoid -> {
try {
- String requestUrl =
getControllerRequestURLBuilder().forSegmentReloadStatus(reloadJobId);
- try {
- SimpleHttpResponse httpResponse =
-
HttpClient.wrapAndThrowHttpException(_httpClient.sendGetRequest(new
URL(requestUrl).toURI(), null));
- PinotTableReloadStatusResponse segmentReloadStatusValue =
- JsonUtils.stringToObject(httpResponse.getResponse(),
PinotTableReloadStatusResponse.class);
- return segmentReloadStatusValue.getSuccessCount() ==
segmentReloadStatusValue.getTotalSegmentCount();
- } catch (HttpErrorStatusException | URISyntaxException e) {
- throw new IOException(e);
- }
+ String response =
getOrCreateAdminClient().getSegmentClient().getSegmentReloadStatus(reloadJobId);
Review Comment:
getSegmentReloadStatus should return PinotTableReloadStatusResponse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
